zero323 commented on a change in pull request #30181:
URL: https://github.com/apache/spark/pull/30181#discussion_r515988300
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1315,9 +1550,16 @@ def date_format(date, format):
pattern letters of `datetime pattern`_. can be used.
.. _datetime pattern:
https://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html
- .. note:: Use when ever possible specialized functions like `year`. These
benefit from a
- specialized implementation.
+ .. versionadded:: 1.5.0
+
+ Notes
+ -----
+ Use when ever possible specialized functions like `year`. These benefit
from a
Review comment:
I know this hasn't been added in this PR, but the grammar seems off.
Maybe we could change it to something like `Whenever possible, use specialized
functions like `year``?
##########
File path: python/pyspark/sql/functions.py
##########
@@ -1315,9 +1550,16 @@ def date_format(date, format):
pattern letters of `datetime pattern`_. can be used.
.. _datetime pattern:
https://spark.apache.org/docs/latest/sql-ref-datetime-pattern.html
- .. note:: Use when ever possible specialized functions like `year`. These
benefit from a
- specialized implementation.
+ .. versionadded:: 1.5.0
+
+ Notes
+ -----
+ Use when ever possible specialized functions like `year`. These benefit
from a
Review comment:
I know this hasn't been added in this PR, but the grammar seems off.
Maybe we could change it to something like `Whenever possible, use specialized
functions like year`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
