sunchao commented on a change in pull request #30193:
URL: https://github.com/apache/spark/pull/30193#discussion_r516300180
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -479,15 +432,16 @@ object DataWritingSparkTask extends Logging {
}
}
-private[v2] trait AtomicTableWriteExec extends V2TableWriteExec with
SupportsV1Write {
+private[v2] trait TableWriteExec extends V2TableWriteExec with SupportsV1Write
{
Review comment:
yes we do, e.g., `WriteToDataSourceV2Exec`.
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -479,15 +432,16 @@ object DataWritingSparkTask extends Logging {
}
}
-private[v2] trait AtomicTableWriteExec extends V2TableWriteExec with
SupportsV1Write {
+private[v2] trait TableWriteExec extends V2TableWriteExec with SupportsV1Write
{
Review comment:
Yes agree the name might be too general. Not sure about
`TableWriteExecWithV1Support` though since it sounds like only support v1
write. What about `TableWriteExecHelper` (since it just expose one helper
method for writing v1/v2 tables) or `TableWriteExecUtil`? I'm not very good at
naming things ...
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/WriteToDataSourceV2Exec.scala
##########
@@ -479,15 +432,16 @@ object DataWritingSparkTask extends Logging {
}
}
-private[v2] trait AtomicTableWriteExec extends V2TableWriteExec with
SupportsV1Write {
+private[v2] trait TableWriteExec extends V2TableWriteExec with SupportsV1Write
{
Review comment:
Yes agree the name might be too general. Not sure about
`TableWriteExecWithV1Support` though since it sounds like only support v1
write. What about `TableWriteExecHelper` (since it just expose one helper
method for writing v1/v2 tables) or `TableWriteExecUtil`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
