srowen commented on a change in pull request #30203: URL: https://github.com/apache/spark/pull/30203#discussion_r516851464
########## File path: sql/core/src/main/scala/org/apache/spark/sql/execution/python/ExtractPythonUDFs.scala ########## @@ -218,13 +218,22 @@ object ExtractPythonUDFs extends Rule[LogicalPlan] with PredicateHelper { } } + private def canonicalizeDeterministic(u: PythonUDF) = { Review comment: OK I see. But surely the safer assumption is that it is not deterministic, if the user doesn't say? I get that it harms perf, but could be a correctness issue? well I trust the judgment of people here that know much more about it ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org