kbendick commented on a change in pull request #30244: URL: https://github.com/apache/spark/pull/30244#discussion_r517736866
########## File path: .github/labeler.yml ########## @@ -0,0 +1,144 @@ +# +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. +# +# Pull Request Labeler Github Action Configuration: https://github.com/marketplace/actions/labeler +# +# Note that we currently cannot use the negatioon operator (i.e. `!`) for miniglob matches as they +# would match any file that doesn't touch them. What's needed is the concept of `any `, which takes a +# list of constraints / globs and then matches all of the constraints for either `any` of the files or +# `all` of the files. +# +# However, `any`/`all` are not supported in a released version and testing off of the `main` branch +# had them not working proprly. While we wait for this issue to be handled upstream, we can remove +# the negative / not matches for now and at least have labels again. +INFRA: + - ".github/**/*" + - "appveyor.yml" + - "tools/**/*" + - "dev/create-release/**/*" + - ".asf.yaml" + - ".gitattributes" + - ".gitignore" + - "dev/github_jira_sync.py" + - "dev/merge_spark_pr.py" + - "dev/run-tests-jenkins*" +BUILD: + # Can be supported when a stable release with correct all/any is released + #- any: ['dev/**/*', '!dev/github_jira_sync.py', '!dev/merge_spark_pr.py', '!dev/.rat-excludes'] + - "dev/**/*" + - "build/**/*" + - "project/**/*" + - "assembly/**/*" + - "**/*pom.xml" + - "bin/docker-image-tool.sh" + - "bin/find-spark-home*" + - "scalastyle-config.xml" + # These can be added in the above `any` clause (and the /dev/**/* glob removed) when + # `any`/`all` support is released + # - "!dev/github_jira_sync.py" + # - "!dev/merge_spark_pr.py" + # - "!dev/run-tests-jenkins*" + # - "!dev/.rat-excludes" +DOCS: + - "docs/**/*" + - "**/README.md" + - "**/CONTRIBUTING.md" +EXAMPLES: + - "examples/**/*" + - "bin/run-example*" +# CORE needs to be updated when all/any are released upstream. +CORE: + # - any: ["core/**/*", "!**/*UI.scala", "!**/ui/**/*"] # If any file matches all of the globs defined in the list started by `any`, label is applied. + - "core/**/*" Review comment: I've yet to take action on this one, but I'm leading towards adding an additional rule for `sql/core/**/*` so as to avoid the resource-managers/kubernetes/core folders while still picking up the "core" SQL files such as Dataset.scala etc. Does anybody have any thoughts on whether or not we'd like the files underneath `./resource-managers/kubernetes/core` to be labeled as `CORE`? My gut tells me no, but I'm still pretty new here so I'll go with whatever you guys suggest. cc @HyukjinKwon @dongjoon-hyun @RussellSpitzer @rdblue After that, I believe this PR is ready to be merged. We will need to open an issue for the `actions/labeler` team to cut a release with `any` / `all` support. Their current suggestion in a relatively old issue (linked in the main issue at https://issues.apache.org/jira/browse/SPARK-33282) is to use the `main` branch (renamed from `master`), but I had difficulty with getting matches using that and overall I'm not that excited about the idea of using a non-released version. I'd prefer to open an issue to cut a release with support for `all` and `any` (we really only need `any` to handle the negated matches correctly), add a link to the issue to the labeler file, and then merge this and update it once said release has been cut. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
