HeartSaVioR commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-722675458
I see you update the PR. Thanks! As you're upmerging the branch instead of rebasing it's uneasy to check the effective changes. Two questions: 1. Does your last update only upmerge with master? It looks like so, but just to confirm. 2. Do you plan to go through my review comments, or let me do it by myself after merging this PR? And the last time I checked with the updated diff, I see some changed lines which is unnecessary (additional indentation or line break which was already passing the style checker). Could you please go through the diff and make sure you don't introduce unnecessary changes? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
