Github user tdas commented on the pull request:
https://github.com/apache/spark/pull/5473#issuecomment-92288077
Its looking pretty good! Here are some preliminary comments. I will do a
more detailed pass tomorrow during the day.
1. There should be tests in the StreamingListenerSuite that tests the local
property setting.
2. In the screenshots, is there any way to limit the max col size of the
error? When there is error, it squishes all the other columns.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
