Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/5434#discussion_r28224511
--- Diff:
streaming/src/main/scala/org/apache/spark/streaming/ui/AllBatchesTable.scala ---
@@ -0,0 +1,114 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.streaming.ui
+
+import scala.xml.Node
+
+import org.apache.spark.streaming.scheduler.BatchInfo
+import org.apache.spark.ui.UIUtils
+
+private[ui] abstract class BatchTableBase(tableId: String) {
+
+ protected def columns: Seq[Node] = {
+ <th>Batch Time</th>
+ <th>Input Size</th>
+ <th>Scheduling Delay</th>
+ <th>Processing Time</th>
+ }
+
+ protected def baseRow(batch: BatchInfo): Seq[Node] = {
+ val batchTime = batch.batchTime.milliseconds
+ val formattedBatchTime =
UIUtils.formatDate(batch.batchTime.milliseconds)
+ val eventCount = batch.receivedBlockInfo.values.map {
+ receivers => receivers.map(_.numRecords).sum
+ }.sum
+ val schedulingDelay = batch.schedulingDelay
+ val formattedSchedulingDelay =
schedulingDelay.map(UIUtils.formatDuration).getOrElse("-")
+ val processingTime = batch.processingDelay
+ val formattedProcessingTime =
processingTime.map(UIUtils.formatDuration).getOrElse("-")
+
+ <td sorttable_customkey={batchTime.toString}>{formattedBatchTime}</td>
+ <td sorttable_customkey={eventCount.toString}>{eventCount.toString}
events</td>
--- End diff --
One small nit that I noticed when i ran it myself. This says `events` where
as else where in the UI it says `records`. Lets change it to `events` to keep
things consistent.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
