Github user Sephiroth-Lin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5479#discussion_r28231958
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -128,10 +128,14 @@ private[spark] class YarnClientSchedulerBackend(
assert(client != null && appId != null, "Application has not been
submitted yet!")
val t = new Thread {
override def run() {
- val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
- logError(s"Yarn application has already exited with state $state!")
- sc.stop()
- Thread.currentThread().interrupt()
+ try {
+ val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
--- End diff --
We interrupt the monitor thread when we call stop(), so don't need to call
sc.stop() again. We add sc.stop() after client.monitorApplication return just
to confirm we can stop SparkContext when app has finished/failed/killed before
we stop SparkContext.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
