cchighman commented on pull request #28841: URL: https://github.com/apache/spark/pull/28841#issuecomment-725771277
> The problem is feedback cycle, not whether @cchighman is busy or not. We are requiring contributors for multiple months to keep on focus, whereas reviewers don't promise anything about the focus on the PR. When @cchighman was active his feedback delay wasn't that long, but the PR stays as it is. Contributors are always in a risk of "wasting time" if PR loses focus from reviewers - it's going to be worse if reviewers ask to put efforts to reflect the change already. > > I'm not sure it will change even if I take this over. If I take this over I'm going to lose my right to vote, making things worse, as in recent days I only look into this. My recent comments are minor, can be addressed via follow-up PR. > > My last concern is that we should make sure the new options don't work on streaming, and the fact should be documented. Other than that, I'll review the PR again majorly checking there's any change during rebase. If anything wasn't changed, I'm +1 given we can resolve minors in follow-up PR. > > @cchighman I guess you're going to be pretty busy, but could you please answer the questions from me - https://github.com/apache/spark/pull/28841#issuecomment-722675458 > > and make a small change that "the new options don't work on streaming, and the fact should be documented"? Yes, I will look into this evening. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
