cloud-fan commented on a change in pull request #30178:
URL: https://github.com/apache/spark/pull/30178#discussion_r521808339
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/optimizer/Optimizer.scala
##########
@@ -806,6 +807,17 @@ object CollapseRepartition extends Rule[LogicalPlan] {
}
}
+/**
+ * Replaces first(col) to nth_value(col, 1) for better performance.
+ */
+object OptimizeWindowFunctions extends Rule[LogicalPlan] {
+ def apply(plan: LogicalPlan): LogicalPlan = plan resolveExpressions {
+ case we @ WindowExpression(AggregateExpression(first: First, _, _, _, _),
spec)
+ if !spec.orderSpec.isEmpty =>
Review comment:
nonEmpty
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
