dongjoon-hyun commented on a change in pull request #30341:
URL: https://github.com/apache/spark/pull/30341#discussion_r521861854
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -539,6 +539,15 @@ object SQLConf {
.booleanConf
.createWithDefault(true)
+ val SUBEXPRESSION_ELIMINATION_CACHE_MAX_ENTRIES =
+ buildConf("spark.sql.subexpressionElimination.cache.maxEntries")
+ .internal()
+ .doc("The maximum entries of the cache used for interpreted
subexpression elimination.")
+ .version("3.1.0")
+ .intConf
+ .checkValue(maxEntries => maxEntries >= 0, "The maximum must not be
negative")
Review comment:
What happens `maxEntries = 0`?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
