Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/5463#discussion_r28283453
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockStore.scala ---
@@ -22,13 +22,18 @@ import java.nio.ByteBuffer
import scala.collection.mutable.ArrayBuffer
import org.apache.spark.Logging
+import org.apache.spark.util.ResourceCleaner
/**
* Abstract class to store blocks.
*/
private[spark] abstract class BlockStore(val blockManager: BlockManager)
extends Logging {
- def putBytes(blockId: BlockId, bytes: ByteBuffer, level: StorageLevel):
PutResult
+ def putBytes(
+ blockId: BlockId,
--- End diff --
nit: these arguments should be double-indented
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
