Github user chenghao-intel commented on a diff in the pull request: https://github.com/apache/spark/pull/5497#discussion_r28283974 --- Diff: sql/core/src/main/scala/org/apache/spark/sql/SQLConf.scala --- @@ -139,6 +141,8 @@ private[sql] class SQLConf extends Serializable { */ private[spark] def codegenEnabled: Boolean = getConf(CODEGEN_ENABLED, "false").toBoolean + private[spark] def useSqlSerializer2: Boolean = getConf(USE_SQL_SERIALIZER2, "false").toBoolean --- End diff -- Instead of using a `Boolean` value, how about use a string type says the `class name` of the Serializer? We probably will add some other Serializer e.g. the codegen version.
--- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastruct...@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org