Github user vanzin commented on a diff in the pull request:
https://github.com/apache/spark/pull/4688#discussion_r28285158
--- Diff:
core/src/main/scala/org/apache/spark/executor/CoarseGrainedExecutorBackend.scala
---
@@ -164,6 +174,9 @@ private[spark] object CoarseGrainedExecutorBackend
extends Logging {
driverConf.set(key, value)
}
}
+ // Periodically update the credentials for this user to ensure HDFS
tokens get updated.
+ val tokenUpdater = new ExecutorDelegationTokenUpdater(driverConf,
SparkHadoopUtil.get.conf)
+ tokenUpdater.updateCredentialsIfRequired()
--- End diff --
This will cause the code to go and check for the new credentials right
away, right? Instead, how about having a `start()` method in
ExecutorDelegationTokenUpdater that just schedules the task? (Then
`updateCredentialsIfRequired` could be private.)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
