Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5208#discussion_r28286721
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkPlan.scala ---
@@ -72,6 +72,12 @@ abstract class SparkPlan extends QueryPlan[SparkPlan]
with Logging with Serializ
def requiredChildDistribution: Seq[Distribution] =
Seq.fill(children.size)(UnspecifiedDistribution)
+ /** Specifies how data is ordered in each partition. */
+ def outputOrdering: Option[Ordering[Row]] = None
--- End diff --
Why did you change this from `Seq[SortOrder]`. I think that was much
better as that exposes the logical expressions that define the order.
`Ordering` is an opaque scala class that may or may not implement a reasonable
equality function.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
