Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/731#discussion_r28288173
--- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala
---
@@ -524,52 +524,25 @@ private[master] class Master(
}
/**
- * Can an app use the given worker? True if the worker has enough memory
and we haven't already
- * launched an executor for the app on it (right now the standalone
backend doesn't like having
- * two executors on the same worker).
+ * Schedule executors to be launched on the workers.There are two modes
of launching executors.
+ * The first attempts to spread out an application's executors on as
many workers as possible,
+ * while the second does the opposite (i.e. launch them on as few
workers as possible). The former
+ * is usually better for data locality purposes and is the default. The
number of cores assigned
--- End diff --
We should split on this sentence to form a new paragraph. Right now it's
one huge chunk of text
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
