HeartSaVioR commented on pull request #30210: URL: https://github.com/apache/spark/pull/30210#issuecomment-726569827
I'd rather avoid the chance of "post-review" whenever possible, but I'd admit everyone has different thoughts. I'm OK with it, and if that's considered here (and no one would be disappointed from post-review), I was clearly wrong. My bad. I hope we prefer to say about "good practice" of doing something instead of saying "whether someone is the right to do something". Everything is technically possible. e.g. I don't think Spark has some sort of BYLAWS which prevents committers to self +1 and push, but I don't leverage it even I still have PRs sitting around years which got LGTM from contributors. It's just because it's a bad practice. Agree to disagree about the different understanding of "details" about good practice of reviewing is OK (because I may be wrong), but I'd be unhappy if we keep saying about the "right". This says I should always start with explicitly vote -1 whenever I start reviewing, which is the only way about the claim of "my right" of reviewer, but no one would do this as we have a belief and huge negative effect on putting veto. And sure I don't change my reviewing practice to start from -1. (That's gonna be just funny.) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
