HyukjinKwon commented on a change in pull request #30346:
URL: https://github.com/apache/spark/pull/30346#discussion_r522721724
##########
File path: python/pyspark/streaming/dstream.py
##########
@@ -449,15 +462,21 @@ def reduceByWindow(self, reduceFunc, invReduceFunc,
windowDuration, slideDuratio
2. "inverse reduce" the old values that left the window (e.g.,
subtracting old counts)
This is more efficient than `invReduceFunc` is None.
- :param reduceFunc: associative and commutative reduce function
- :param invReduceFunc: inverse reduce function of `reduceFunc`; such
that for all y,
- and invertible x:
- `invReduceFunc(reduceFunc(x, y), x) = y`
- :param windowDuration: width of the window; must be a multiple of this
DStream's
- batching interval
- :param slideDuration: sliding interval of the window (i.e., the
interval after which
- the new DStream will generate RDDs); must be a
multiple of this
- DStream's batching interval
+ Parameters
+ ----------
+ reduceFunc : func
Review comment:
```suggestion
reduceFunc : function
```
##########
File path: python/pyspark/streaming/dstream.py
##########
@@ -449,15 +462,21 @@ def reduceByWindow(self, reduceFunc, invReduceFunc,
windowDuration, slideDuratio
2. "inverse reduce" the old values that left the window (e.g.,
subtracting old counts)
This is more efficient than `invReduceFunc` is None.
- :param reduceFunc: associative and commutative reduce function
- :param invReduceFunc: inverse reduce function of `reduceFunc`; such
that for all y,
- and invertible x:
- `invReduceFunc(reduceFunc(x, y), x) = y`
- :param windowDuration: width of the window; must be a multiple of this
DStream's
- batching interval
- :param slideDuration: sliding interval of the window (i.e., the
interval after which
- the new DStream will generate RDDs); must be a
multiple of this
- DStream's batching interval
+ Parameters
+ ----------
+ reduceFunc : func
+ associative and commutative reduce function
+ invReduceFunc : func
Review comment:
```suggestion
invReduceFunc : function
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
