dongjoon-hyun commented on a change in pull request #30357:
URL: https://github.com/apache/spark/pull/30357#discussion_r523464426
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/parser/ExpressionParserSuite.scala
##########
@@ -200,12 +200,12 @@ class ExpressionParserSuite extends AnalysisTest {
}
test("like expressions with ESCAPED_STRING_LITERALS = true") {
- val conf = new SQLConf()
- conf.setConfString(SQLConf.ESCAPED_STRING_LITERALS.key, "true")
- val parser = new CatalystSqlParser(conf)
- assertEqual("a rlike '^\\x20[\\x20-\\x23]+$'", 'a rlike
"^\\x20[\\x20-\\x23]+$", parser)
- assertEqual("a rlike 'pattern\\\\'", 'a rlike "pattern\\\\", parser)
- assertEqual("a rlike 'pattern\\t\\n'", 'a rlike "pattern\\t\\n", parser)
+ withSQLConf(SQLConf.ESCAPED_STRING_LITERALS.key -> "true") {
Review comment:
This style changes look like another benefit. Thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
