zero323 commented on a change in pull request #30346:
URL: https://github.com/apache/spark/pull/30346#discussion_r523750158
##########
File path: python/pyspark/streaming/kinesis.pyi
##########
@@ -32,15 +35,15 @@ class KinesisUtils:
regionName,
initialPositionInStream,
checkpointInterval,
- storageLevel: Any = ...,
- awsAccessKeyId: Optional[Any] = ...,
- awsSecretKey: Optional[Any] = ...,
- decoder: Any = ...,
- stsAssumeRoleArn: Optional[Any] = ...,
- stsSessionName: Optional[Any] = ...,
- stsExternalId: Optional[Any] = ...,
+ storageLevel: StorageLevel = ...,
+ awsAccessKeyId: Optional[str] = ...,
+ awsSecretKey: Optional[str] = ...,
+ decoder: Callable[[T], T] = ...,
Review comment:
This should be
```python
Callable[[Optional[bytes]], T] = ...,
```
shouldn't it?
And since w already modify the file, maybe
```python
def utf8_decoder(s: Optional[bytes]) -> str: ...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
