cloud-fan commented on a change in pull request #30380:
URL: https://github.com/apache/spark/pull/30380#discussion_r523951682
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -729,6 +729,7 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
def unapply(expr: Expression): Option[Attribute] = {
expr match {
case attr: Attribute => Some(attr)
+ case Cast(IntegralType(), StringType, _) => None
Review comment:
good catch! I'm thinking if we should be more conservative here. How
about
```
case Cast(child @ IntegralType(), dt: IntegralType, _) => if
Cast.canUpCast...
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
