dongjoon-hyun commented on a change in pull request #30352:
URL: https://github.com/apache/spark/pull/30352#discussion_r524482948
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
##########
@@ -374,6 +389,16 @@ private[spark] class MesosClusterScheduler(
s"${frameworkId}-${desc.submissionId}${retries}"
}
+ private[mesos] def getDriverPriority(desc: MesosDriverDescription): Float = {
+ val queueName =
+ desc.conf.get("spark.mesos.dispatcher.queue",
config.DISPATCHER_QUEUE.defaultValueString)
+ if (queueName != config.DISPATCHER_QUEUE.defaultValueString) {
+ queues.getOrElse(queueName, throw new NoSuchElementException(queueName))
Review comment:
~Do we have a test case for this `NoSuchElementException`?~
I found here,
https://github.com/apache/spark/pull/30352/files#diff-4cacb8999398615a7e9fe82d96fabc3764ee69168dbf98e148fbd91818eb9a99R623
.
##########
File path:
resource-managers/mesos/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosClusterScheduler.scala
##########
@@ -374,6 +389,16 @@ private[spark] class MesosClusterScheduler(
s"${frameworkId}-${desc.submissionId}${retries}"
}
+ private[mesos] def getDriverPriority(desc: MesosDriverDescription): Float = {
+ val queueName =
+ desc.conf.get("spark.mesos.dispatcher.queue",
config.DISPATCHER_QUEUE.defaultValueString)
+ if (queueName != config.DISPATCHER_QUEUE.defaultValueString) {
+ queues.getOrElse(queueName, throw new NoSuchElementException(queueName))
Review comment:
~Do we have a test case for this `NoSuchElementException`?~
Never mind. I found here,
https://github.com/apache/spark/pull/30352/files#diff-4cacb8999398615a7e9fe82d96fabc3764ee69168dbf98e148fbd91818eb9a99R623
.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
