viirya commented on a change in pull request #30341: URL: https://github.com/apache/spark/pull/30341#discussion_r524815671
########## File path: sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/SubExprEvaluationRuntimeSuite.scala ########## @@ -0,0 +1,99 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ +package org.apache.spark.sql.catalyst.expressions + +import org.apache.spark.SparkFunSuite + +class SubExprEvaluationRuntimeSuite extends SparkFunSuite { + + test("Evaluate ExpressionProxy should create cached result") { + val runtime = new SubExprEvaluationRuntime(1) + val proxy = ExpressionProxy(Literal(1), runtime) + assert(runtime.cache.size() == 0) + proxy.eval() + assert(runtime.cache.size() == 1) + assert(runtime.cache.get(proxy) == ResultProxy(1)) + } + + test("SubExprEvaluationRuntime cannot exceed configured max entries") { + val runtime = new SubExprEvaluationRuntime(2) + assert(runtime.cache.size() == 0) + + val proxy1 = ExpressionProxy(Literal(1), runtime) + proxy1.eval() + assert(runtime.cache.size() == 1) + assert(runtime.cache.get(proxy1) == ResultProxy(1)) + + val proxy2 = ExpressionProxy(Literal(2), runtime) + proxy2.eval() + assert(runtime.cache.size() == 2) + assert(runtime.cache.get(proxy2) == ResultProxy(2)) + + val proxy3 = ExpressionProxy(Literal(3), runtime) + proxy3.eval() + assert(runtime.cache.size() == 2) + assert(runtime.cache.get(proxy3) == ResultProxy(3)) + } + + test("setInput should empty cached result") { + val runtime = new SubExprEvaluationRuntime(2) + val proxy1 = ExpressionProxy(Literal(1), runtime) + assert(runtime.cache.size() == 0) + proxy1.eval() + assert(runtime.cache.size() == 1) + assert(runtime.cache.get(proxy1) == ResultProxy(1)) + + val proxy2 = ExpressionProxy(Literal(2), runtime) + proxy2.eval() + assert(runtime.cache.size() == 2) + assert(runtime.cache.get(proxy2) == ResultProxy(2)) + + runtime.setInput() + assert(runtime.cache.size() == 0) + } + + test("Wrap ExpressionProxy on subexpressions") { + val runtime = new SubExprEvaluationRuntime(1) + + val one = Literal(1) + val two = Literal(2) + val mul = Multiply(one, two) + val mul2 = Multiply(mul, mul) + val sqrt = Sqrt(mul2) + val sum = Add(mul2, sqrt) + + // ( (one * two) * (one * two) ) + sqrt( (one * two) * (one * two) ) + val proxyExpressions = runtime.proxyExpressions(Seq(sum)) + val proxys = proxyExpressions.flatMap(_.collect { + case p: ExpressionProxy => p + }) + // ( (one * two) * (one * two) ) + assert(proxys.size == 2) + val expected = ExpressionProxy(mul2, runtime) + assert(proxys.head == expected) + } + + test("ExpressionProxy won't be on non deterministic") { + val runtime = new SubExprEvaluationRuntime(1) + + val sum = Add(Rand(0), Rand(0)) + val proxys = runtime.proxyExpressions(Seq(sum, sum)).flatMap(_.collect { + case p: ExpressionProxy => p + }) + assert(proxys.isEmpty) + } +} Review comment: `EquivalentExpressions` skips for `LeafExpression`. So attributes won't be counted for subexpression. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
