viirya edited a comment on pull request #30392: URL: https://github.com/apache/spark/pull/30392#issuecomment-729205954
> I guess I'd just say, do you have any evidence it speeds things up? If not I wouldn't change it. if it clearly helps in more imaginable cases than it hurts, OK. Yeah, it makes sense. I also said above I will run benchmark later. Just trying to run against Jenkins test to see if anything is not broken. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
