HeartSaVioR commented on pull request #30366: URL: https://github.com/apache/spark/pull/30366#issuecomment-729336028
https://github.com/apache/hadoop/commit/22039a14ff2b9d280f71b0735c32e6ac717e2344 Please take a look at the commit message body. `AbstractDelegationTokenIdentifier` has issue date and max date as 0L by default, and being assigned when `AbstractDelegationTokenSecretManager.createPassword` is called. That said, any token identifiers which don't follow the path should initialize issue date and max date by themselves. `AbstractS3ATokenIdentifier` extends `AbstractDelegationTokenIdentifier`, but includes `getCreated()` and `getExpiryTime()` as well which look to conflict with issue date and max date. Implementations of `AbstractS3ATokenIdentifier` may try to provide the correct values for both methods, but at the risk of not updating issue date and max date. I actually encountered this from internal class (in our org), but we just made sure at least issue date is valid for `AbstractS3ATokenIdentifier` by HADOOP-17379. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
