HyukjinKwon commented on a change in pull request #30391: URL: https://github.com/apache/spark/pull/30391#discussion_r526037235
########## File path: .github/workflows/build_and_test.yml ########## @@ -433,11 +407,32 @@ jobs: key: scala-213-coursier-${{ hashFiles('**/pom.xml', '**/plugins.sbt') }} restore-keys: | scala-213-coursier- - - name: Install Java 11 + - name: Install Java 8 uses: actions/setup-java@v1 with: - java-version: 11 + java-version: 8 - name: Build with SBT run: | ./dev/change-scala-version.sh 2.13 ./build/sbt -Pyarn -Pmesos -Pkubernetes -Phive -Phive-thriftserver -Phadoop-cloud -Pkinesis-asl -Djava.version=11 -Pscala-2.13 compile test:compile + Review comment: @mridulm, oh but if there's any of them fails, it shows a clear X like ![Screen Shot 2020-11-18 at 9 07 02 PM](https://user-images.githubusercontent.com/6477701/99528700-077e5680-29e2-11eb-9769-f27b414657da.png) So it should be fine. I do believe reviewers check the X or test failures from Jenkins before merging it in :-). Actually, Java 11 and Scala 2.13 too. PR builder does not run them as well. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org