Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/5505#discussion_r28348897
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -121,7 +121,7 @@ class DataFrameSuite extends QueryTest {
         )
       }
     
    -  test("self join with aliases") {
    +  ignore("self join with aliases") {
    --- End diff --
    
    The more I think about this, the more I am worried that we can't make a 
change this large.  There is no way to express self join queries if we don't 
handle `.` in column names.  We are also going to break lots of existing user 
code...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org

Reply via email to