Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/5467#discussion_r28360417
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -431,6 +431,14 @@ class Word2Vec extends Serializable with Logging {
class Word2VecModel private[mllib] (
private val model: Map[String, Array[Float]]) extends Serializable
with Saveable {
--- End diff --
Don't store this any more. Store wordVecMat, plus a matching collection of
words; that collection should probably be a Map[String, Int] mapping word to
index in wordVecMat (so that transform() is still fast).
Naming: How about "wordVectors" instead of "wordVecMat"?
You'll need to update getVectors to construct the map.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
