Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/5350#discussion_r28379010
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/sources/interfaces.scala ---
@@ -126,6 +126,13 @@ abstract class BaseRelation {
* could lead to execution plans that are suboptimal (i.e. broadcasting
a very large table).
*/
def sizeInBytes: Long = sqlContext.conf.defaultSizeInBytes
+
+ /**
+ * Whether does it need to convert the objects in Row to internal
representation, for example:
+ * java.lang.String -> UTF8String
+ * java.lang.Decimal -> Decimal
+ */
+ def needConversion: Boolean = true
--- End diff --
We should comment that the internal representation is not stable across
releases and thus data sources outside of Spark SQL should leave this as true.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
