[GitHub] [spark] mridulm commented on a change in pull request #30433: [SPARK-32916][SHUFFLE][test-maven][test-hadoop2.7] Ensure the number of chunks in meta file and index file are equal

[GitBox]

mridulm commented on a change in pull request #30433:
URL: https://github.com/apache/spark/pull/30433#discussion_r528175717



##########
File path: 
common/network-shuffle/src/main/java/org/apache/spark/network/shuffle/RemoteBlockPushResolver.java
##########
@@ -877,7 +886,7 @@ void closeAllFiles() {
       }
       if (metaFile != null) {
         try {
-          // if the stream is closed, channel get's closed as well.
+          metaFile.setLength(metaFile.getFilePointer());
           metaFile.close();

Review comment:
       Move close to finally (here and below)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org