Github user andrewor14 commented on a diff in the pull request:
https://github.com/apache/spark/pull/5063#discussion_r28385856
--- Diff:
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/MesosSchedulerBackend.scala
---
@@ -67,6 +67,8 @@ private[spark] class MesosSchedulerBackend(
// The listener bus to publish executor added/removed events.
val listenerBus = sc.listenerBus
+
+ val executorCores = sc.conf.getDouble("spark.mesos.executor.cores", 1)
--- End diff --
This variable should be renamed `mesosExecutorCores`. In Spark, whenever we
see the word "executor" we automatically think of Spark executors. Just having
`executorCores` here is somewhat misleading.
Also, I know the rest of this file doesn't do this, but can you make this
`private[mesos]` so it's clear that it's only read within this package?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
