wangyum commented on a change in pull request #30408:
URL: https://github.com/apache/spark/pull/30408#discussion_r529214802
##########
File path:
sql/hive/src/main/scala/org/apache/spark/sql/hive/client/HiveShim.scala
##########
@@ -700,6 +709,21 @@ private[client] class Shim_v0_13 extends Shim_v0_12 {
}
}
+ object ExtractableDateValues {
+ private lazy val valueToLiteralString: PartialFunction[Any, String] = {
+ case value: Int => dateFormatter.format(value)
+ }
+
+ def unapply(values: Set[Any]): Option[Seq[String]] = {
+ val extractables = values.toSeq.map(valueToLiteralString.lift)
+ if (extractables.nonEmpty && extractables.forall(_.isDefined)) {
Review comment:
Otherwise this test will fail:
```scala
filterTest("string filter with InSet predicate",
(InSet(a("stringcol", StringType),
Range(1, 10).map(d => UTF8String.fromString(d.toString)).toSet)) ::
Nil,
"")
```
```
None.get
java.util.NoSuchElementException: None.get
at scala.None$.get(Option.scala:529)
at scala.None$.get(Option.scala:527)
at
org.apache.spark.sql.hive.client.Shim_v0_13$ExtractableDateValues$1$.$anonfun$unapply$7(HiveShim.scala:720)
at
scala.collection.TraversableLike.$anonfun$map$1(TraversableLike.scala:238)
at scala.collection.Iterator.foreach(Iterator.scala:941)
at scala.collection.Iterator.foreach$(Iterator.scala:941)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
