MaxGekk commented on a change in pull request #30474:
URL: https://github.com/apache/spark/pull/30474#discussion_r529375116
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolvePartitionSpec.scala
##########
@@ -65,31 +65,8 @@ object ResolvePartitionSpec extends Rule[LogicalPlan] {
conf.resolver)
val partValues = partSchema.map { part =>
- val partValue = normalizedSpec.get(part.name).orNull
- if (partValue == null) {
- null
- } else {
- // TODO: Support other datatypes, such as DateType
- part.dataType match {
- case _: ByteType =>
- partValue.toByte
- case _: ShortType =>
- partValue.toShort
- case _: IntegerType =>
- partValue.toInt
- case _: LongType =>
- partValue.toLong
- case _: FloatType =>
- partValue.toFloat
- case _: DoubleType =>
- partValue.toDouble
- case _: StringType =>
- partValue
- case _ =>
- throw new AnalysisException(
- s"Type ${part.dataType.typeName} is not supported for
partition.")
- }
- }
+ val raw = normalizedSpec.get(part.name).orNull
+ Cast(Literal.create(raw, StringType), part.dataType,
Some(conf.sessionLocalTimeZone)).eval()
Review comment:
I reused the code from DSv1 https://github.com/apache/spark/pull/30482
and fixed an issue.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
