dongjoon-hyun commented on a change in pull request #30283:
URL: https://github.com/apache/spark/pull/30283#discussion_r529783873
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/LoggingPodStatusWatcher.scala
##########
@@ -42,13 +44,20 @@ private[k8s] trait LoggingPodStatusWatcher extends
Watcher[Pod] {
*/
private[k8s] class LoggingPodStatusWatcherImpl(
appId: String,
- maybeLoggingInterval: Option[Long])
+ maybeLoggingInterval: Option[Long],
+ waitForCompletion: Boolean)
Review comment:
~Please revert this change. This is inconsistent with Apache Spark 3.1
and 3.0.~
##########
File path:
resource-managers/kubernetes/core/src/main/scala/org/apache/spark/deploy/k8s/submit/KubernetesClientApplication.scala
##########
@@ -230,7 +242,9 @@ private[spark] class KubernetesClientApplication extends
SparkApplication {
val master = KubernetesUtils.parseMasterUrl(sparkConf.get("spark.master"))
val loggingInterval = if (waitForAppCompletion)
Some(sparkConf.get(REPORT_INTERVAL)) else None
- val watcher = new LoggingPodStatusWatcherImpl(kubernetesAppId,
loggingInterval)
+ val watcher = new LoggingPodStatusWatcherImpl(kubernetesAppId,
+ loggingInterval,
+ waitForAppCompletion)
Review comment:
~Please revert this change. This is inconsistent with Apache Spark 3.1
and 3.0.~
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
