otterc commented on a change in pull request #30312: URL: https://github.com/apache/spark/pull/30312#discussion_r529830075
########## File path: core/src/main/scala/org/apache/spark/internal/config/package.scala ########## @@ -1992,4 +1992,32 @@ package object config { .version("3.1.0") .doubleConf .createWithDefault(5) + + private[spark] val SHUFFLE_NUM_PUSH_THREADS = + ConfigBuilder("spark.shuffle.push.numPushThreads") + .doc("Specify the number of threads in the block pusher pool. These threads assist " + + "in creating connections and pushing blocks to remote shuffle services when push based " + + "shuffle is enabled. By default, the threadpool size is equal to the number of cores.") + .version("3.1.0") + .intConf + .createOptional + + private[spark] val SHUFFLE_MAX_BLOCK_SIZE_TO_PUSH = + ConfigBuilder("spark.shuffle.push.maxBlockSizeToPush") + .doc("The max size of an individual block to push to the remote shuffle services when push " + + "based shuffle is enabled. Blocks larger than this threshold are not pushed.") + .version("3.1.0") + .bytesConf(ByteUnit.KiB) + .createWithDefaultString("800k") Review comment: @Victsm could you please address this one? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org