imback82 commented on a change in pull request #30490:
URL: https://github.com/apache/spark/pull/30490#discussion_r529836248
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/catalyst/analysis/ResolveSessionCatalog.scala
##########
@@ -467,25 +467,13 @@ class ResolveSessionCatalog(
v1TableName.asTableIdentifier,
partitionSpec)
- case ShowColumnsStatement(tbl, ns) =>
- if (ns.isDefined && ns.get.length > 1) {
- throw new AnalysisException(
- s"Namespace name should have only one part if specified:
${ns.get.quoted}")
- }
Review comment:
Note that this is not hit anymore now that namespace is always added to
the table name in `AstBuilder` so that v2 tables can be resolved.
If there are multi parts in the namespace name, it will fail while looking
up in the session catalog: `The namespace in session catalog must have exactly
one name part`. I added a test for this below.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
