zero323 commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733328865
__Side note__ @HyukjinKwon > Looking at [`numpy.ndarray.item`](https://numpy.org/devdocs/reference/generated/numpy.ndarray.item.html) we should make varargs explicit > > ``` > *cols : ... > ``` This approach, especially with enumeration of possible types, looks rather useful. Shall we use consider using it, especially in cases, where just a list of types is a bit ambiguous? For example `struct` https://github.com/apache/spark/blob/95b6dabc33515f1975eb889480ccca12bf5ac3c8/python/pyspark/sql/functions.py#L1294-L1298 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
