HyukjinKwon commented on pull request #30413: URL: https://github.com/apache/spark/pull/30413#issuecomment-733348463
@zero323, the only reason I have chosen `cols` over `*cols` is that I felt odds to just document this such as `*cols : tuple`, and thought `` cols: str, :class:`Column` ... `` is clearer. I took a look at https://numpydoc.readthedocs.io/en/latest/example.html: > ``` > *args : iterable > Other arguments. > long_var_name : {'hi', 'ho'}, optional > Choices in brackets, default first when optional. > **kwargs : dict > Keyword arguments. > ``` If there's other way arounds and it's still standard of numpydoc (or at least numpy itself uses it), I am fine either way. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
