AngersZhuuuu commented on a change in pull request #30421:
URL: https://github.com/apache/spark/pull/30421#discussion_r530059949
##########
File path: docs/sql-ref-syntax-dml-insert-into.md
##########
@@ -41,7 +41,7 @@ INSERT INTO [ TABLE ] table_identifier [ partition_spec ]
* **partition_spec**
An optional parameter that specifies a comma separated list of key and
value pairs
- for partitions.
+ for partitions. Here we support use type constructed value as partition
col value.
Review comment:
> btw, `a type constructed value` is a common word in the user's doc?
I've checked the literal doc, but I couldn't find it:
https://spark.apache.org/docs/3.0.1/sql-ref-literals.html
I. will raise a pr to add this part.
##########
File path: docs/sql-ref-syntax-dml-insert-into.md
##########
@@ -41,7 +41,7 @@ INSERT INTO [ TABLE ] table_identifier [ partition_spec ]
* **partition_spec**
An optional parameter that specifies a comma separated list of key and
value pairs
- for partitions.
+ for partitions. Here we support use type constructed value as partition
col value.
Review comment:
> btw, `a type constructed value` is a common word in the user's doc?
I've checked the literal doc, but I couldn't find it:
https://spark.apache.org/docs/3.0.1/sql-ref-literals.html
I. will raise a pr to add this part.
https://issues.apache.org/jira/browse/SPARK-33547
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
