cloud-fan commented on a change in pull request #30494:
URL: https://github.com/apache/spark/pull/30494#discussion_r530339227
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/OptimizeSkewedJoin.scala
##########
@@ -55,6 +55,11 @@ import org.apache.spark.sql.internal.SQLConf
*/
object OptimizeSkewedJoin extends Rule[SparkPlan] {
+ /**
+ * The list of [[ShuffleOrigin]]s supported by this rule.
+ */
+ val supportedShuffleOrigins: Seq[ShuffleOrigin] = Seq(ENSURE_REQUIREMENTS)
Review comment:
should the rule `OptimizeSkewedJoin` itself check it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
