cloud-fan commented on a change in pull request #30440:
URL: https://github.com/apache/spark/pull/30440#discussion_r530360448
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1876,6 +1894,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString}.
+ | To convert values from ${from.catalogString} to
${to.catalogString}, you can use functions
TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
+ |""".stripMargin
+
+ case (_: ArrayType, StringType) =>
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString} with
ANSI mode on.
+ | If you have to cast ${from.catalogString} to ${to.catalogString},
you can use the function array_join or set $fallbackConfKey as
$fallbackConfValue.
Review comment:
upper case the function nama?
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1876,6 +1894,35 @@ object AnsiCast {
case _ => false
}
+
+ def typeCheckFailureMessage(
+ from: DataType,
+ to: DataType,
+ fallbackConfKey: String,
+ fallbackConfValue: String): String =
+ (from, to) match {
+ case (_: NumericType, TimestampType) =>
+ // scalastyle:off line.size.limit
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString}.
+ | To convert values from ${from.catalogString} to
${to.catalogString}, you can use functions
TIMESTAMP_SECONDS/TIMESTAMP_MILLIS/TIMESTAMP_MICROS instead.
+ |""".stripMargin
+
+ case (_: ArrayType, StringType) =>
+ s"""
+ | cannot cast ${from.catalogString} to ${to.catalogString} with
ANSI mode on.
+ | If you have to cast ${from.catalogString} to ${to.catalogString},
you can use the function array_join or set $fallbackConfKey as
$fallbackConfValue.
Review comment:
upper case the function name?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
