[GitHub] [spark] AngersZhuuuu commented on a change in pull request #30131: [SPARK-33220][CORE]Use `scheduleWithFixedDelay` to avoid repeated unnecessary scheduling for a short time

[GitBox]

AngersZhuuuu commented on a change in pull request #30131:
URL: https://github.com/apache/spark/pull/30131#discussion_r530711869



##########
File path: core/src/main/scala/org/apache/spark/Heartbeater.scala
##########
@@ -45,7 +45,8 @@ private[spark] class Heartbeater(
     val heartbeatTask = new Runnable() {
       override def run(): Unit = Utils.logUncaughtExceptions(reportHeartbeat())
     }
-    heartbeater.scheduleAtFixedRate(heartbeatTask, initialDelay, intervalMs, 
TimeUnit.MILLISECONDS)
+    heartbeater.scheduleWithFixedDelay(
+      heartbeatTask, initialDelay, intervalMs, TimeUnit.MILLISECONDS)

Review comment:
       Done

##########
File path: 
core/src/main/scala/org/apache/spark/executor/ExecutorMetricsPoller.scala
##########
@@ -99,7 +99,7 @@ private[spark] class ExecutorMetricsPoller(
   def start(): Unit = {
     poller.foreach { exec =>
       val pollingTask: Runnable = () => Utils.logUncaughtExceptions(poll())
-      exec.scheduleAtFixedRate(pollingTask, 0L, pollingInterval, 
TimeUnit.MILLISECONDS)
+      exec.scheduleWithFixedDelay(pollingTask, 0L, pollingInterval, 
TimeUnit.MILLISECONDS)
     }
   }

Review comment:
       revert this




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org