Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/5197#discussion_r28416458
--- Diff: core/src/main/scala/org/apache/spark/storage/BlockManager.scala
---
@@ -589,10 +589,11 @@ private[spark] class BlockManager(
private def doGetRemote(blockId: BlockId, asBlockResult: Boolean):
Option[Any] = {
require(blockId != null, "BlockId is null")
val locations = Random.shuffle(master.getLocations(blockId))
+ val timeout = conf.getInt("spark.storage.fetchBlockTimeout", 1000) //
seconds
--- End diff --
We now have support for retrieving properties specified like "1000s", so
it'd be best to use that.
Rather than proliferating so many different timeout values, how about using
`spark.network.timeout`? at least, this should fall back on that like others do.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
