cloud-fan commented on pull request #30421: URL: https://github.com/apache/spark/pull/30421#issuecomment-734049999
Let's do it step by step, and support typed literal first. We can figure out how to eliminate the string <-> actual value roundtrip in v2 commands later. Let's make sure this feature works correctly: 1. All the literals are supported. Non-literals are forbidden. e.g. `part_col=array(1)` does not create a string value "array(1)". 2. Null literal is supported. We should use null instead of "null" to represent it. 3. If the literal data type doesn't match the partition column data type, we should do type check and cast like normal table insertion. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
