maropu commented on a change in pull request #30212:
URL: https://github.com/apache/spark/pull/30212#discussion_r531391314
##########
File path:
sql/catalyst/src/main/antlr4/org/apache/spark/sql/catalyst/parser/SqlBase.g4
##########
@@ -593,13 +593,24 @@ fromClause
;
aggregationClause
- : GROUP BY groupingExpressions+=expression (','
groupingExpressions+=expression)* (
+ : GROUP BY groupingExpressionWithGroupingAnalytics+=groupByClause
+ (',' groupingExpressionWithGroupingAnalytics+=groupByClause)*
Review comment:
nit: It seems we need the two more spaces at the beginning.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
