leanken commented on a change in pull request #30442:
URL: https://github.com/apache/spark/pull/30442#discussion_r531412245
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -945,6 +934,36 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
cast("abcd", DecimalType(38, 1)),
"invalid input syntax for type numeric")
}
+
+ test("ANSI mode: cast string to timestamp with parse error") {
+ val currentAnsiEnabled = SQLConf.get.ansiEnabled
+ new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ def checkCastWithParseError(str: String): Unit = {
+ checkExceptionInExpression[DateTimeException](
+ cast(Literal(str), TimestampType, Option(zid.getId)),
+ s"Cannot cast $str to TimestampType.")
+ }
+
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> currentAnsiEnabled.toString) {
+ checkCastWithParseError("123")
+ checkCastWithParseError("2015-03-18 123142")
+ checkCastWithParseError("2015-03-18T123123")
+ checkCastWithParseError("2015-03-18X")
+ checkCastWithParseError("2015/03/18")
+ checkCastWithParseError("2015.03.18")
+ checkCastWithParseError("20150318")
+ checkCastWithParseError("2015-031-8")
+ checkCastWithParseError("2015-03-18T12:03:17-0:70")
+ }
+ }
+ }
+
+ test("ANSI mode: timestamp type casting with parse error") {
Review comment:
merged in one test
##########
File path:
sql/catalyst/src/test/scala/org/apache/spark/sql/catalyst/expressions/CastSuite.scala
##########
@@ -945,6 +934,36 @@ abstract class AnsiCastSuiteBase extends CastSuiteBase {
cast("abcd", DecimalType(38, 1)),
"invalid input syntax for type numeric")
}
+
+ test("ANSI mode: cast string to timestamp with parse error") {
+ val currentAnsiEnabled = SQLConf.get.ansiEnabled
+ new ParVector(ALL_TIMEZONES.toVector).foreach { zid =>
+ def checkCastWithParseError(str: String): Unit = {
+ checkExceptionInExpression[DateTimeException](
+ cast(Literal(str), TimestampType, Option(zid.getId)),
+ s"Cannot cast $str to TimestampType.")
+ }
+
+ withSQLConf(SQLConf.ANSI_ENABLED.key -> currentAnsiEnabled.toString) {
Review comment:
done
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeExpressions.scala
##########
@@ -720,10 +720,12 @@ case class DateFormatClass(left: Expression, right:
Expression, timeZoneId: Opti
case class ToUnixTimestamp(
timeExp: Expression,
format: Expression,
- timeZoneId: Option[String] = None)
+ timeZoneId: Option[String] = None,
+ failOnError: Boolean = SQLConf.get.ansiEnabled)
extends UnixTime {
Review comment:
done.
##########
File path:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/Cast.scala
##########
@@ -1254,10 +1260,11 @@ abstract class CastBase extends UnaryExpression with
TimeZoneAwareExpression wit
ctx.addReferenceObj("zoneId", zoneId, zoneIdClass.getName),
zoneIdClass)
val longOpt = ctx.freshVariable("longOpt", classOf[Option[Long]])
+ val stringToTimestampFunc = if (ansiEnabled) "stringToTimestampAnsi"
else "stringToTimestamp"
Review comment:
done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
