AngersZhuuuu edited a comment on pull request #30212: URL: https://github.com/apache/spark/pull/30212#issuecomment-734679145
> > In postgres sql, it support > > > select a, b, c, count(1) from t group by a, b, cube(a, b, c); > > > select a, b, c, count(1) from t group by a, c, grouping sets (a, b, (a, b)); > > Could you remove the two PostgreSQL examples above in the PR description? I think the examples is out-of-scope of this PR and they make reviewers confused. Yea, that is another problem. remove and and two more case about cube/rollup support groupingset ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org For additional commands, e-mail: reviews-h...@spark.apache.org
