cloud-fan commented on a change in pull request #30403:
URL: https://github.com/apache/spark/pull/30403#discussion_r532360022
##########
File path:
sql/core/src/main/scala/org/apache/spark/sql/execution/command/cache.scala
##########
@@ -19,26 +19,27 @@ package org.apache.spark.sql.execution.command
import java.util.Locale
-import org.apache.spark.sql.{Dataset, Row, SparkSession}
-import org.apache.spark.sql.catalyst.TableIdentifier
+import org.apache.spark.sql.{AnalysisException, DataFrame, Dataset, Row,
SparkSession}
import org.apache.spark.sql.catalyst.plans.QueryPlan
import org.apache.spark.sql.catalyst.plans.logical.{IgnoreCachedData,
LogicalPlan}
import org.apache.spark.sql.catalyst.util.CaseInsensitiveMap
+import
org.apache.spark.sql.connector.catalog.CatalogV2Implicits.MultipartIdentifierHelper
import org.apache.spark.storage.StorageLevel
case class CacheTableCommand(
Review comment:
the next thing we can do is to refactor it using the v2 framework (not
adding a v2 version). The benefits are: 1. moving the logical plan to catalyst.
2. resolve the table in the analyzer. e.g.
```
CacheTable(UnresolvedRelation(...), ...)
...
case class CacheTableExec(relation: LogicalPlan) {
def run() {
val df = Dataset.ofRows(spark, relation)
....
}
}
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
