HyukjinKwon commented on a change in pull request #30486:
URL: https://github.com/apache/spark/pull/30486#discussion_r532966969
##########
File path: core/src/test/scala/org/apache/spark/SparkContextSuite.scala
##########
@@ -160,6 +160,85 @@ class SparkContextSuite extends SparkFunSuite with
LocalSparkContext with Eventu
}
}
+ test("SPARK-33530: basic case for addArchive and listArchives") {
+ withTempDir { dir =>
+ val file1 = File.createTempFile("someprefix1", "somesuffix1", dir)
+ val file2 = File.createTempFile("someprefix2", "somesuffix2", dir)
+ val file3 = File.createTempFile("someprefix3", "somesuffix3", dir)
+ val file4 = File.createTempFile("someprefix4", "somesuffix4", dir)
+
+ val jarFile = new File(dir, "test!@$jar.jar")
+ val zipFile = new File(dir, "test-zip.zip")
Review comment:
I manually tested tar.gz and tgz cases, and the cases without extensions
too. The unpack method is a copy from Hadoop so I did not exhaustively test but
I can add if that looks better to add the case.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
