Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/5173#discussion_r28483601
--- Diff: python/pyspark/mllib/feature.py ---
@@ -216,7 +221,10 @@ def __init__(self, numFeatures=1 << 20):
def indexOf(self, term):
""" Returns the index of the input term. """
- return hash(term) % self.numFeatures
+ # hash of string is not portable in Python 3
+ if isinstance(term, unicode):
+ term = term.encode('utf-8')
+ return (binascii.crc32(term) & 0x7FFFFFFF) % self.numFeatures
--- End diff --
Any performance overhead with the new approach?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscr...@spark.apache.org
For additional commands, e-mail: reviews-h...@spark.apache.org
